Hi Guillaume, > test/hangup | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-)
this is a case where you should have done a summary email to describe why are you doing things. > > diff --git a/test/hangup b/test/hangup > index 6444b23..60858a8 100755 > --- a/test/hangup > +++ b/test/hangup > @@ -3,6 +3,16 @@ > import sys > import dbus > > +if (len(sys.argv) < 2): > + print "Usage: %s <call state>" % (sys.argv[0]) > + sys.exit(1) > + > +cstate = sys.argv[1] > + > +if cstate != "active" and cstate != "waiting" and cstate != "held": > + print "Valid <call state> is active / waiting / held" > + sys.exit(1) > + If you wanna do things like this, then at least the call without parameter should list the current calls and in what state they are. Otherwise this is making things worse. And don't bother renaming the script first. Just introduce a new script and delete the duplicate later on. Regards Marcel _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
