Hi Anthony,

On 03/22/2013 05:36 AM, Anthony Viallard wrote:
Add a quirk for AT+CNMI command building.

Use mode=1 otherwise it fails (ref. SIM5215_SIM5216_ATC_V1.18.pdf - ยง6.9)


You might want to quote the relevant section in the patch description. Otherwise it looks good to me, but I still can't apply it. Please use git send-email.

--- ofono-1.12.orig/drivers/atmodem/sms.c       2012-04-20 21:06:29.000000000 
+0200
+++ ofono-1.12/drivers/atmodem/sms.c    2013-01-21 16:48:44.460627485 +0100
@@ -805,6 +807,7 @@ static gboolean build_cnmi_string(char *
        case OFONO_VENDOR_NOVATEL:
        case OFONO_VENDOR_HUAWEI:
        case OFONO_VENDOR_ZTE:
+       case OFONO_VENDOR_SIMCOM:
                /* MSM devices advertise support for mode 2, but return an
                 * error if we attempt to actually use it. */
                mode = "1";



_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to