Hi Nishanth, On 04/19/2016 10:28 PM, Nishanth V wrote:
--- Makefile.am | 9 +- doc/allowed-apns-api.txt | 17 +++ plugins/allowed-apns.c | 272 ++++++++++++++++++++++++++++++++++++++++ src/simutil.c | 1 + test/list-allowed-access-points | 25 ++++ 5 files changed, 322 insertions(+), 2 deletions(-) create mode 100644 doc/allowed-apns-api.txt create mode 100644 plugins/allowed-apns.c create mode 100755 test/list-allowed-access-points
Looks good, but please submit this as a series. Remember our patch submission guidelines can be found in HACKING 'Submitting patches' section.
So: - one patch for doc/allowed-apns-api.txt + makefile specific changes - one patch for simutil.c changes - one patch for the plugin + required makefile changes - one patch for test script + required makefile makefile Regards, -Denis _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
