Hi Philippe,

On 12/06/2017 09:36 AM, Philippe De Swert wrote:
Add a new function to be able to dial numbers from memory/favourites.

---
  include/voicecall.h | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/include/voicecall.h b/include/voicecall.h
index 79a64bb4..6c4f3f5f 100644
--- a/include/voicecall.h
+++ b/include/voicecall.h
@@ -61,6 +61,11 @@ struct ofono_voicecall_driver {
                        const struct ofono_phone_number *number,
                        enum ofono_clir_option clir, ofono_voicecall_cb_t cb,
                        void *data);
+       /* dials a number at a given memory location */
+       void (*dial_memory)(struct ofono_voicecall *vc,
+                       long int memory_location,

Why a long int?  Memory indexes are always positive, no?

Do note that size of long will be different between 32 bit and 64 bit architectures.

I would think an unsigned int would be sufficient here

+                       enum ofono_clir_option clir, ofono_voicecall_cb_t cb,
+                       void *data);
        /* Dials the last number again, this handles the hfp profile last number
           * dialing with the +BLDN AT command
           */


Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to