Hi Gabriel, Mariem,

On 03/16/2018 07:59 AM, Gabriel Lucas wrote:
From: Mariem Cherif <mariem.che...@ardia.com.tn>

---
  drivers/atmodem/network-registration.c | 45 ++++++++++++++++++++++++++++++++++
  1 file changed, 45 insertions(+)

When applying this patch I got:

  CC       drivers/atmodem/network-registration.o
drivers/atmodem/network-registration.c: In function ‘cinterion_parse_tech’:
drivers/atmodem/network-registration.c:186:10: error: unused variable ‘l’ [-Werror=unused-variable]
  GSList *l;
          ^
drivers/atmodem/network-registration.c: At top level:
cc1: error: unrecognized command line option ‘-Wno-format-truncation’ [-Werror]
cc1: all warnings being treated as errors

Please make sure you test with --disable-debug --enable-optimization prior to submission so the compiler catches any unused variables.

I went ahead and removed the offending GSList *l declaration and applied this patch. Thanks!

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to