Hi,

On 09/18/2018 03:36 PM, ClémentViel wrote:
From: clem <vielclem...@gmail.com>


You might want to describe how this is different from sim900 that it warrants a fully separate driver?

If there are only minor differences, then this can be handled via UDEV attributes or querying +CGMM, etc.

---
  Makefile.am      |   4 +
  plugins/sim800.c | 424 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 428 insertions(+)
  create mode 100644 plugins/sim800.c


<snip>

+
+static void sim800_post_sim(struct ofono_modem *modem)
+{
+       struct sim800_data *data = ofono_modem_get_data(modem);
+       struct ofono_gprs *gprs;
+       struct ofono_gprs_context *gc;
+
+       DBG("%p", modem);
+
+       /* Dirty Hack : give some time to sim800 for multiplexing
+        *                              to be effective and avoid VOICE_DLC to 
be
+        *                              flooded thus leading to a "famine" 
situation
+        */
+
+       sleep(2);

No sleeps inside plugins. That blocks the entire daemon and we can't have that. How does this help you anyway? GAtChat is a queue, so only 1 command is outstanding at a time.

+       ofono_sms_create(modem, OFONO_VENDOR_SIMCOM, "atmodem",
+                                               data->dlcs[SMS_DLC]);
+
+
+       gprs = ofono_gprs_create(modem, 0, "atmodem", data->dlcs[GPRS_DLC]);
+       if (gprs == NULL)
+               return;
+
+       gc = ofono_gprs_context_create(modem, OFONO_VENDOR_SIMCOM,
+                                       "atmodem", data->dlcs[GPRS_DLC]);
+       if (gc)
+               ofono_gprs_add_context(gprs, gc);
+}
+

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to