Hi Giacinto,

On 10/22/2018 01:56 PM, Giacinto Cifelli wrote:
This function converts the ofono enum ofono_gprs_auth_method
into the value of the 3GPP 27.007 to pass to the AT command
---
  drivers/atmodem/atutil.c | 16 ++++++++++++++++
  drivers/atmodem/atutil.h |  3 +++
  2 files changed, 19 insertions(+)


Your commit header does not match the patch contents or description. You might want to slow down a bit.

Anyway, I renamed this to at_util_gprs_auth_method_to_auth_proto to match 3GPP naming & the naming of the pdp_type conversion function in the next patch. And fixed up the commit description / header.

Applied, thanks.

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to