Hi,

Could I get a clarification on the behaviour you see here?

As I understand it, the SARA-R4 doesn't support the CGDATA command. That's fine as ofono will detect this and set use_atd99 in order to force the use of the ATD command as a fallback.

Why do you need to force this setting in the below patch? Does the CGDATA command not return ERROR? What does it return?

Thanks,
Jonas

On 15/02/2019 13:11, philippedesw...@gmail.com wrote:
From: Philippe De Swert <philippe.desw...@digitalistgroup.com>

QUIRCK: For some reason I really need to force the use of the atd99 command 
here.
---
  drivers/atmodem/gprs-context.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
index 93894efd..a0776f2a 100644
--- a/drivers/atmodem/gprs-context.c
+++ b/drivers/atmodem/gprs-context.c
@@ -214,7 +214,7 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, 
gpointer user_data)
                return;
        }
- if (gcd->use_atd99)
+       if (gcd->use_atd99 || gcd->vendor == OFONO_VENDOR_UBLOX)
                sprintf(buf, "ATD*99***%u#", gcd->active_context);
        else
                sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
@@ -457,6 +457,9 @@ static int at_gprs_context_probe(struct ofono_gprs_context 
*gc,
        case OFONO_VENDOR_SIMCOM_SIM900:
                gcd->use_atd99 = FALSE;
                break;
+       case OFONO_VENDOR_UBLOX:
+               gcd->use_atd99 = TRUE;
+               break;
        default:
                g_at_chat_send(chat, "AT+CGDATA=?", cgdata_prefix,
                                                at_cgdata_test_cb, gc, NULL);

_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to