Hi Martin,

On 7/19/19 7:39 AM, Martin Hundebøll wrote:
---

Changes since v2:
  * Use Voltage{High,Low} instead of {High,Low}Power

Changes since v1:
  * new patch split out from PATCHv1 7/7

  doc/quectel-hardware-api.txt | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)

diff --git a/doc/quectel-hardware-api.txt b/doc/quectel-hardware-api.txt
index 6aafbfd8..8795ef40 100644
--- a/doc/quectel-hardware-api.txt
+++ b/doc/quectel-hardware-api.txt
@@ -10,6 +10,25 @@ Methods              array{string,variant} GetProperties
                        Returns hardware properties for the modem object. See
                        the properties section for available properties.
+Signals PowerDown(string reason)
+
+                       This signal is emitted on gracefull shutdowns initiated
+                       by the modem.
+
+                       Possible reasons:
+                               "VoltageLow"  The supply voltage is too low
+                               "Normal"      The PWRKEY pin was asserted
+                               "VoltageHigh" The supply voltage is too high
+
+               PowerWarning(string reason)
+
+                       This signal is emitted when the modem detects its supply
+                       voltage is close to its supported limits.
+
+                       Possible reasons:
+                               "VoltageLow"  The supply voltage is low
+                               "VoltageHigh" The supply voltage is high

So just another nitpick, but our APIs use CamelCase for Property names and Member names (signals, method calls). However, the values are always lower case.

+
  Properties    int32 Voltage [readonly]
Integer with the modem supply voltage in mV.


Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to