Hi Jonas, Den ons 21 aug. 2019 kl 08:01 skrev Jonas Bonn <jo...@norrbonn.se>:
> Hi Richard, > > On 20/08/2019 17:56, richard.rojf...@gmail.com wrote: > > From: Richard Röjfors <rich...@puffinpack.se> > > > > This reverts commit 1fd419e5b4b3a87673f8e0219edb0f3ed9fca774. > > This patch is fine and certainly necessary in the context of this > series. Posting it as a 'revert', however, is a bit unsavoury. > > A reverted patch implies that it was somehow wrong or inappropriate. > That's not the case here. This code has become superfluous in the face > of other changes that have been made in the tree. > I agree, this did not introduce any obvious bug, but the other revert did. > > Just squash these two revert patches into one "forward looking" patch. > The fact that the change effectively constitutes a 'revert' is moot. > For me it doesn't matter its the same effect. Denis, whats your opinion? I think you have the final say. --Richard
_______________________________________________ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
