Hi Martin,
On 10/7/19 4:39 PM, Martin Hundebøll wrote:
The in-kernel implementation of gsm0710 causes deadlocks in the
kernel[1], so switch the default back to the user-space implementation
in ofono.
The change also removes the timeout-callback used to defer disabling the
n_gsm line discipline, as that is no longer needed[2]
To enable use of the kernel line discipline, add an udev env entry with
OFONO_QUECTEL_MUX="n_gsm".
[1]
https://lore.kernel.org/lkml/4b2455c0-25ba-0187-6df6-c63b4ccc6...@geanix.com/
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7030082a7415d18e3befdf1f9ec05b3d5de98de4
---
Changes since v2:
* keep kernel line discipline support
* remove unrelated check in quectel_disable()
* remove unrelated setting of AT+IFC=0,0
* revert to using at_util_open_device()
plugins/quectel.c | 202 ++++++++++++++++++++++++++++++++++++----------
plugins/udevng.c | 5 ++
2 files changed, 166 insertions(+), 41 deletions(-)
I split this patch up into two and squashed this warning:
plugins/quectel.c:936:14: error: unused variable ‘device’
[-Werror=unused-variable]
936 | GIOChannel *device;
| ^~~~~~
by taking out the offending variable declaration.
Applied, thanks.
Regards,
-Denis
_______________________________________________
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
