Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
* Allows us to notice when a function becomes source incompatible in a Qt major
release,
and our implementation stops overriding.
---
src/aidapplication.cpp | 3 ++-
src/aidapplication.h | 4 ++--
src/callmanager.h | 2 +-
src/control.h | 18 +++++++--------
src/hardwaremanipulator.cpp | 1 +
src/phonesim.h | 16 +++++++-------
src/qatutils.cpp | 44 ++++++++++++++++++-------------------
src/qgsmcodec.h | 10 ++++-----
src/qwsppdu.cpp | 6 ++---
src/qwsppdu.h | 4 ++--
src/simapplication.h | 20 ++++++++---------
src/simauth.h | 2 +-
src/simfilesystem.h | 4 ++--
13 files changed, 68 insertions(+), 66 deletions(-)
diff --git a/src/aidapplication.cpp b/src/aidapplication.cpp
index 807d7f9..395fe99 100644
--- a/src/aidapplication.cpp
+++ b/src/aidapplication.cpp
@@ -190,7 +190,8 @@ bool AidAppWrapper::command( const QString& cmd )
return true;
}
- break;
+ // if CMD_TYPE_GSM_AUTH is the case, we already returned
+ // and can't fallthrough, so no break here
This doesn't seem to belong in this patch, so I left it out.
case CMD_TYPE_UMTS_AUTH:
{
enum UmtsStatus status;
<snip>
diff --git a/src/hardwaremanipulator.cpp b/src/hardwaremanipulator.cpp
index ea895e7..63c498a 100644
--- a/src/hardwaremanipulator.cpp
+++ b/src/hardwaremanipulator.cpp
@@ -363,4 +363,5 @@ void HardwareManipulator::simAppAbort()
void HardwareManipulator::callManagement( QList<CallInfo> *info )
{
+ Q_UNUSED(info)
}
Same here
Rest applied, thanks.
Regards,
-Denis
_______________________________________________
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
