Re: [PATCH 1/3] droid 4: add special handling required for voice calls and SIM

[Denis Kenzior]

Hi Pavel,

On 9/15/20 8:23 AM, Pavel Machek wrote:

Droid 4 modem is "special" (aka broken) so it seems to need a bit of
error handling.
---
  drivers/atmodem/sim.c       | 1 +
  drivers/atmodem/vendor.h    | 1 +
  drivers/atmodem/voicecall.c | 4 ++++
  3 files changed, 6 insertions(+)

<snip>

@@ -160,6 +160,10 @@ static void clcc_poll_cb(gboolean ok, GAtResult *result, 
gpointer user_data)
                        poll_again = TRUE;
                        goto poll_again;
                }

applied with an extra newline here to satisfy doc/coding-style.txt item M1.

+               if (vd->vendor == OFONO_VENDOR_DROID) {
+                       poll_again = TRUE;
+                       goto poll_again;
+               }

ofono_error("We are polling CLCC and received an error");

                ofono_error("All bets are off for call management");

Regards,
-Denis
_______________________________________________
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org