Indeed a newer IOCTL shouldn't change versions. On the other hand the partitioning support has also changed the interface of ipoib_ofc.h (which actually has it's own version). I believe that this is the change that broke the applications.
Next time I'll pay more attention to the versions. Thanks Tzachi > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Sean Hefty > Sent: Friday, May 30, 2008 8:37 AM > To: 'Fab Tillier'; [email protected] > Subject: RE: [ofw] changes to ibbus in SVN rev 1160 > > >Revision 1160 added partitioning support. This introduced a > new IOCTL, > >however the AL_IOCTL_VERSION wasn't updated. Anytime the IOCTLs are > >changed this needs to be updated so that applications fail > gracefully > >if there's a version mismatch. > > A new IOCTL shouldn't require updating the version. A new > app that uses the IOCTL with an older kernel would simply get > an error when it tried to issue the request. Other > combinations of old/new apps/kernel won't see any issues. If > you update the version, then you've broken all existing apps, > none of which use the new IOCTL. > > - Sean > > _______________________________________________ > ofw mailing list > [email protected] > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw > _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
