To address bugzilla bug #1150 - error message in uninstall wsd.
The following patch moves the confusing file delete error messages into the 
checked version of installsp.exe.
The confusing error messages occur when WSD is not enabled and 'installsp -r' 
is executed.
On rare occations, I have seen the error messages when WSD is enabled and 
'installsp -r' is executed.
Bottom-line: error messages can confuse the user into believing something 
is/was not right with WSD uninstall.

Sometimes too much information is not good - Best to leave these error messages 
for developers.

If you approve, I can check into trunk\ and branches\WOF2-0\.

Stan.

--- installsp.c 2008-10-15 09:55:57.548673600 -0700
+++ installsp.c.new     2008-10-14 14:22:40.188639600 -0700
@@ -282,6 +282,7 @@
                goto Cleanup;
        }

+#if DBG
        if( !DeleteFile( ibsp_pm_ini_file ) )
        {
                fprintf( stderr, "Delete file %s failed status %d\n",
@@ -292,6 +293,10 @@
                fprintf( stderr,"Delete file %s failed status %d\n",
                        ibsp_pm_sym_file, GetLastError() );
        }
+#else
+       (void) DeleteFile( ibsp_pm_ini_file );
+       (void) DeleteFile( ibsp_pm_sym_file );
+#endif

 Cleanup:
        if ( ibsp_pm_sym_file )

Attachment: installsp.c.patch
Description: installsp.c.patch

_______________________________________________
ofw mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw

Reply via email to