On Sun, Sep 27, 2009 at 1:45 AM, Ralph Versteegen <teeem...@gmail.com> wrote:
> 2009/9/25 <subvers...@hamsterrepublic.com>:
>> james
>> 2009-09-24 09:11:32 -0700 (Thu, 24 Sep 2009)
>> 242
>> Apply a modification of David's patch to warn of possible corruption when
>> binsize shrinks
>> All I changed was to move the check to updaterecordlength() instead of
>> setbinsize()
>> because setbinsize doesn't get called unless the change is positive
>> ---
>> U wip/common.bas
>
>
> I think that Neo's original patch made sense, but this doesn't. This
> is basically equivalent to preventing some arbitrarily chosen majority
> (since some binsize is bound to get incremented fairly regularly) of
> games newer than the version of Game/Custom from being loaded at all.
>
> Binsize was meant to be both forward and backward compatible: if the
> data record contains stuff you don't understand you can still load it,
> and with 90% likelyhood the meaning of the older data will still be
> the same.
I had originally considered a threshold, and perhaps that might be a
better option.
say .. 100 (for game), and the current behaviour (for custom)
What I mean is something like:
Warn if you load a game with larger than expected binsize values (like
the current warning for old RPG files, really)
Warn really obnoxiously ('the behaviour of the game may be impossible
or gibberish') if the difference is more than 100
Refuse to load newer-than-we-understand games in custom (or do a backupy thing)
_______________________________________________
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
