On Thu, Feb 17, 2011 at 03:44:12PM +1300, Ralph Versteegen wrote: > On 17 February 2011 06:12, James Paige <[email protected]> wrote: > > mjohnson just pointed out on a slimesalad thread that menu item tags get > > set AFTER the menu action. > > > > For the "Save" menu, this is guaranteed to be the wrong thing to do, and > > the more I think about it, the more it seems wrong for all special menu > > types... (except possibly text boxes?) > > > > I feel like I need to add a menu item bitset to control whether the tag > > setting happens before or after the menu action. > > > > What I want to discuss is what the default should be, and what the > > possible backcompat consequences could be if the default is the reverse > > of what it is now. > > > > ---- > > James > > Actually, it turns out that I already made tag changes occur before a > triggered textbox is loaded in r3751 without realising it. Opps.
My thought on text boxes from menus is that a tag would most often mean "I already saw this text box" and therefore it might matter for instead-chaining of the first text box. > Do tags actually affect any menu actions aside from loading textboxes > and saving the game (and hero/item special tags which is already a > fixed bug)? Changing tags after saving the game doesn't sound like a > bug which I'd expect anyone to be relying on. Yeah, fixing just the "save" case seems really safe. Rather than a bitset, maybe a Default/Before/After choice is the way to go? --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
