Now, here is the question!

Do we fix this by saving the intended return value for addhero and then 
restoring it at the right moment when the on-add-hero script exists?

Or do we fix it by documenting that and on-add-hero script trigger's return 
value replaces the return value of the addhero command?

I am leaning towards the first, even though the implementation seems like it 
might be a little hacky, it seems to be the more correct thing to do, and the 
"feature" of returning the result of the on-add-hero script instead seems 
unwanted and annoying

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1186#issuecomment-751488882
_______________________________________________
Ohrrpgce mailing list
[email protected]
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org

Reply via email to