Hi, On 26 Nov 2013, at 11:27, Alexander Pyhalov <a...@rsu.ru> wrote:
> On 11/25/2013 22:42, Jim Klimov wrote: >> On 2013-11-25 16:27, Alexander Pyhalov wrote: >>> Hello. >>> >>> Please, review http://cr.illumos.org/~webrev/alp/3395/ >> >> Can't the Makefile blocks like this: >> >> profile: etc-profile.sh >> $(RM) profile >> $(CP) etc-profile.sh $@ >> >> be remade into this: >> >> profile: etc-profile.sh >> $(RM) $@ >> $(CP) $< $@ >> >> This would simplify copy-pasting of standardized actions :) > > $(CP) $< $@ part doesn't work: > > $ dmake clean install > /usr/bin/rm -f profile > /usr/bin/cp -f profile > cp: Insufficient arguments (1) > Usage: cp [-a] [-f] [-i] [-p] [-@] [-/] f1 f2 > cp [-a] [-f] [-i] [-p] [-@] [-/] f1 ... fn d1 > cp [-r|-R [-H|-L|-P]] [-a] [-f] [-i] [-p] [-@] [-/] d1 ... dn-1 dn > *** Error code 2 > You should almost certainly be using $(INS.file) instead here. As somebody involved with distros I welcome these changes. Andy. > > > -- > Best regards, > Alexander Pyhalov, > system administrator of Computer Center of Southern Federal University > > _______________________________________________ > oi-dev mailing list > oi-dev@openindiana.org > http://openindiana.org/mailman/listinfo/oi-dev
_______________________________________________ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev