I'm fine with that, it was just a name I made up off the top of my head. Also note that I put the test for alpha=1 before the "is it monochrome" test. So it will correctly collapse CCC1 textures to C, if you know what I mean, whereas previously CCC1 textures would not only keep the pointless alpha, they also would fail to recognize the texture as monochrome (except for the very rare case of C==1).
On Aug 30, 2011, at 1:59 PM, Solomon Boulos wrote: > --opaque-detect? > > --alpha1-detect doesn't seem to really match --monochrome-detect and > --constant-detect. > > > On Aug 30, 2011, at 1:56 PM, Larry Gritz wrote: > >> https://github.com/OpenImageIO/oiio/pull/153 >> >> maketx --alpha1-detect will omit alpha from textures whose input images had >> designated alpha channels that were 1.0 for all pixels. Somewhat similar in >> operation to --monochrome-detect and --constant-detect. >> >> Also adds ImageBufAlgo::isConstantChannel() utility and does some minor >> cleanup/simplification to isConstantColor. >> >> (Yes, this is because we have textures with pointless alpha=1 everywhere, >> and it's easier to fix in image-to-texture conversion than it is to actually >> fix the problem upstream.) >> -- Larry Gritz [email protected] _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
