On Mar 25, 2012, at 9:20 PM, Justina Mickonytė wrote: > test_convert_type: errors only occur while converting from data > types larger in bytes to smaller, and back.
That's expected, though, right? It obviously can't preserve all the precision, so it's not really a "failure". test_convert_type<T,F> is only expected to work if F has at least as much range and precision as T. > test_bit_range_convert: only fails with more than 32 bits (that exceeds int > size). It's not expected to work in those cases, since the "in" parameter is in fact an int. > I got a bit familiar with the code before applying for GSoC. This time I only > tested on a Linux machine. Should I try the code I add on all major platforms? If you have access to multiple platforms, it would be best if you could test on all that you have. But many of us only have easy access to a subset, so it is definitely not a requirement. We're usually good at spotting which changes have a higher chance at being tricky to get working on all platforms and in those cases it's fine to say "I could only test on Linux, but I'm worried about Windows, can somebody else give this a try?" or something like that. For this particular set of changes, I'm not concerned, I don't see how it would be different on other platforms, and even if it was, we could fix it at our leisure, amending this test can't break anybody's software. -- Larry Gritz [email protected] _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
