For what it's worth, I've never seen a .cin file that wasn't 10-bit ints. So either choice - or a segfault, or an exception - beats the compile warning in my book. ;)
-- Jeremy On Wed, Apr 18, 2012 at 11:22 PM, Larry Gritz <l...@larrygritz.com> wrote: > We're getting some compiler warnings (have for a long time, now I'm > investigating) in the Cineon code. > > Looking at > src/cineon.imageio/libcineon/Writer.cpp (circa line 284) > src/dpx.imageio/libdpx/Writer.cpp (circa line 313) > > See how they're different? No warnings result from DPX. > > I'm wondering if the Cineon code is supposed to be like DPX in this spot. > Does anybody know? It seems to be about writing 32 bit Cineon files. It > looks to me as if the DPX code is assuming that 32 and 64 bit output is > always float, but Cineon in the analogous spot assumes int (but the code that > handles it is clearly wrong, if you follow it into the WriteBuffer > implementation, which does not appear to handle >16 bits). > > Does anybody agree or disagree that the Cineon code here should look just > like DPX? > > -- > Larry Gritz > l...@larrygritz.com > > > _______________________________________________ > Oiio-dev mailing list > Oiio-dev@lists.openimageio.org > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org _______________________________________________ Oiio-dev mailing list Oiio-dev@lists.openimageio.org http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
