On Jul 23, 2012, at 9:51 AM, Stefan Stavrev wrote:
> "oiiotool A.png --pattern constant=0.1,0.1,0.1 1x1 3 --add -o B.png"
I really like the idea of overloading --add to understand that if it gets an
argument that is obviously a number or comma-separated list of numbers (and
doesn't match a filename), it should add it as a constant. And internally to
IBA, I'm happy to just have multiple IBA::add() entry points:
bool IBA::add (IB &R, const RB &A, const RB &B);
bool IBA::add (IB &R, const RB &A, const float *pixel, int nchans);
bool IBA::add (IB &R, const RB &A, float value);
The other idea of making constant-valued temporary images seems clunky and
wasteful.
> Another question is, what do we do for the users that don't know
> what brightness adjustment is? The ones that know can add
> a constant as we do above but what if they don't?
>
> I think we should have a brightness function, Photoshop, GIMP
> and others have it and I assume many users won't know what
> brightness adjustment is.
I'm fine with having another command-line argument that's essentially an alias
to make the mnemonic easier. "--addbrightness"?
Although I'm also fine with just leaving it as just "add", I honestly don't
think it will be a problem.
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
