On Oct 29, 2013, at 3:18 PM, Jonathan Egstad <[email protected]> wrote:
> 1) src/include/export.h Line 78: > #if __GNUC__ >= 4 > > If it is newer than 4.1.2 this works, in 4.1.2 we get compile errors. Aha, I did not have the precise set of gcc versions available to narrow it down to a particular minor release. https://github.com/OpenImageIO/oiio/pull/732 Does this appear to fix it? If you say it works, I'll merge it back to 1.2 as well. > 2) libutil/strutil.cpp Line 94: > #ifdef va_copy > va_copy (apsave, ap); > #else > apsave = ap; > #endif > > apsave = ap; causes compilation errors under icc12.1-64bit but not gcc: > src/libutil/strutil.cpp(94): error: expression must be a modifiable lvalue > apsave = ap; > ... > compilation aborted for src/libutil/strutil.cpp (code 2) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > scons: *** [build/opt-debug-icc12.1_64/src/libutil/strutil.os] Error 2 > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reversing the variables makes the errors go away, but is this correct? No, the order is definitely correct -- the idea is to save ap so that we can try the whole thing again with a bigger buffer (but need to restore ap to do so). I'm not sure why it doesn't let you do this. I'll continue to look into it. -- Larry Gritz [email protected]
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
