Hi Larry, I'm not affiliated with github in any way, these are just a couple of thoughts on my experience with using it.
With regard to 2), I would guess that githubs angle might be that it's the responsibility of the PR author to make such changes. On my last team, we'd review PR's, offer up feedback and the author of the PR would clean it up. It was only ever an edge case that someone else would have to take ownership. It may be better generally to offer that feedback to contributors so they can follow the same guidelines for future PR's. If you modify the actual PR commits then it's understandable it won't get picked up. Would adding your minor changes as additional commits to the same PR close it? 5) Given the multitude of services appearing for this, and the fact it requires a bunch of engineers with differing skillsets to straight source control, I think it unlikely that github is going to introduce any kind of offering in this space soon. Travis-CI seems to be free for open source projects and supports C/C++, so may be worth a look: https://travis-ci.org/. Ian On Thu, Nov 19, 2015 at 10:03 PM, Larry Gritz <[email protected]> wrote: > Just ranting about some features that I would love to see added to GitHub, > which would make my life as a project administrator a whole lot easier. > Maybe somebody who sees this is from GH, or has influence in some way. > > 1. Some projects like to maintain as close to a linear history as > practical. It would be great if the "merge" button for a pull request had > an option that would do the rebase-atop-master + > optionally-squash-into-one-commit + reset-master, rather than a regular > merge. > > 2. As project leader, sometimes I need to clean up somebody's PR just a > bit before I can merge it into the project. Maybe I want a bit of > reformatting, or they forgot to modify the docs, or I want a minor change > that's easier for me to do as part of the merge than for me to kick it back > and explain exactly how I want some extremely picky minor change. So I pull > their PR locally, make the change, and then merge/push. Unfortunately, if I > modify some or all of their commits before pushing, GH doesn't notice that > the PR has been accepted and close the ticket. I have to do so manually, > and then manually close the PR and any associated issues. But then, it > looks abandoned. So the suggestion is that we needs a button that means "I > merged this", as distinct from "I want to withdraw/abandon this PR". > > 3. It would be really nice to fully merge a PR and an issue. Right now, > you can refer from one to the other, but that spreads the discussion across > two places. It would be better if we could directly open a review/pull > request into an existing issue, if you know what I mean, and thereby have > one consistent discussion. > > 4. Another pattern that I see happening is that somebody submits a PR, and > somebody else wants to take it, modify it, and submit the modification as > an alternate proposal to resolving the same issue. It would be great to > have a formal way to do that, which keeps all of the discussion about both > proposals on the same ticket/page, and so that if the alternate is merged, > it properly closes the original PR. > > 5. Hosted VM build bot. I WOULD BE VERY HAPPY TO PAY EXTRA FOR THIS. I > would love to be able to point to any branch of anybody's repo of my > project (such as somebody's pull request) and have that branch built on one > or a variety of platforms hosted as VMs on GH's servers, so that I would be > confident that the merge I'm about to do will not break the software, > especially for platforms I don't have easy access to. I know, I could > probably set something up on various cloud services, but it would be > tremendously easier to just have it be a service I could pay for and use on > the same site that hosts my repos. Please, take my money! > > -- > Larry Gritz > [email protected] > > > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
