I already backported the chromaticities fix to RB-1.6, but I wasn't planning to create a tagged release for a couple weeks. But if you want to just use the current head of RB-1.6, that's fine.
> On Sep 14, 2016, at 9:10 PM, Andrew Gartner <[email protected]> wrote: > > Sorry busy day and took forever to get back to you on this.. > > Patching back the chromaticities behavior would be helpful in 1.6, but yea I > don't want to pull anything from 1.7 because that sounds like a nasty merge > for you (and me). I'm perfectly fine waiting till I can move to 1.7 for the > extra oiiotool options. > > Either way i can run with the patch if for some reason there's objection to > moving that stuff back to 1.6 > > ~Andrew > > On Tue, Sep 13, 2016 at 6:40 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > I can certainly backport this exr fix to 1.6. I'm slightly more hesitant > about backporting the "--attrib" extensions for oiiotool, mostly because I > don't remember what they in turn depend on or what else was included in the > same patch. > > But the high point is that we're on track to in the next few weeks switch to > considering 1.7 to be the supported production release, so even the stuff i > won't backport will no longer be considered experimental. > > >> On Sep 13, 2016, at 5:48 PM, Andrew Gartner <[email protected] >> <mailto:[email protected]>> wrote: >> >> Ah ok, that would make much more sense then. Also do you have any objections >> to back porting this to 1.6? (DIdn't check if that MR only went into >> master). >> >> Also, awesome news on 1.7! >> >> ~Andrew >> >> On Tue, Sep 13, 2016 at 5:33 PM, Larry Gritz <[email protected] >> <mailto:[email protected]>> wrote: >> Ah... I can't quite remember when we extended the --attrib syntax to have >> the extra bits to let you set oddball types, but it's possible that you're >> using an OIIO that's just too old to support that, so it's still not getting >> the type right with oiiotool. >> >> I see now, looks like that was a 1.7 feature. Coincidentally, I'm planning >> to branch 1.7 for the first beta tonight! >> >> >>> On Sep 13, 2016, at 5:19 PM, Andrew Gartner <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Sounds like a plan to me, shouldn't hold up a merge at all considering all >>> went well on the code side. Maybe I'm behind on the source tree but I >>> could've sworn I'm on 1.6 release. >>> >>> Thanks for the fixes regardless, this is more than enough to get me moving. >>> I'll try to find some time to dig at what differences I may have in my >>> source tree too. >>> >>> Cheers, >>> >>> ~Andrew >>> >>> On Tue, Sep 13, 2016 at 4:29 PM, Larry Gritz <[email protected] >>> <mailto:[email protected]>> wrote: >>> Because this works for me and passes the CI tests, I'm going to >>> speculatively merge it. If it turns out that your difficulties are a bug >>> and not something weird with your setup, we can always patch it. >>> >>> >>>> On Sep 13, 2016, at 2:28 PM, Larry Gritz <[email protected] >>>> <mailto:[email protected]>> wrote: >>>> >>>> No match? Wha? >>>> >>>> Which version of OIIO? >>>> >>>> Just for fun, try enclosing the "-attrib:type=float[8]" in double quotes, >>>> in case the shell is getting confused by the brackets. >>>> >>>> It works for me, BTW. >>>> >>>> >>>>> On Sep 13, 2016, at 2:09 PM, Andrew Gartner <[email protected] >>>>> <mailto:[email protected]>> wrote: >>>>> >>>>> Sure thing, here's what i get in my shell with this command. I'm guessing >>>>> it's an argument syntax issue to be honest. (sorry I can't include the >>>>> images for legal reasons). >>>>> >>>>> oiiotool input.exr -attrib:type=float[8] chromaticities >>>>> "0.680,0.320,0.265,0.690,0.150,0.060,0.3127,0.3290" -o output.exr >>>>> oiiotool: No match. >>>>> >>>>> >>>>> >>>>> On Tue, Sep 13, 2016 at 1:59 PM, Larry Gritz <[email protected] >>>>> <mailto:[email protected]>> wrote: >>>>> Not finding a match? Can you clarify? (Like, with a command line and >>>>> exactly what the error says?) >>>>> >>>>> You're right, OpenEXR says the name should be lowercase, I will fix that >>>>> in the patch. >>>>> >>>>> >>>>> >>>>>> On Sep 13, 2016, at 1:28 PM, Andrew Gartner <[email protected] >>>>>> <mailto:[email protected]>> wrote: >>>>>> >>>>>> Hey Larry, >>>>>> >>>>>> Thanks for the super fast response. >>>>>> >>>>>> The patch worked from python like a charm once I set the type desc to >>>>>> the attribute call to float[8]. I did notice it automatically >>>>>> capitalizes the attribute name in the header on writing, is that a >>>>>> concern at all? >>>>>> >>>>>> Also oiiotool still complained about not finding a match when I tried >>>>>> your above syntax but like I said, python worked fine. >>>>>> >>>>>> Cheers and thanks again, >>>>>> >>>>>> ~Andrew >>>>>> >>>>>> On Tue, Sep 13, 2016 at 12:23 PM, Larry Gritz <[email protected] >>>>>> <mailto:[email protected]>> wrote: >>>>>> Yep, sorry, this was subtly broken for OpenEXR. >>>>>> >>>>>> This patch should fix it: https://github.com/OpenImageIO/oiio/pull/1487 >>>>>> <https://github.com/OpenImageIO/oiio/pull/1487> >>>>>> >>>>>> Let me know if you need that backported to a release branch. >>>>>> >>>>>> >>>>>> >>>>>> > On Sep 13, 2016, at 11:49 AM, Larry Gritz <[email protected] >>>>>> > <mailto:[email protected]>> wrote: >>>>>> > >>>>>> > I think the correct syntax is: >>>>>> > >>>>>> > oiiotool input.exr -attrib:type=float[8] chromaticities >>>>>> > "0,1,0,0,0,0,0,0" -o output.exr >>>>>> > >>>>>> > But upon trying it, I see that it's not quite working. Hang on, let me >>>>>> > poke around a bit. OpenEXR may be particular about how the >>>>>> > chromaticities are declared. >>>>>> > >>>>>> > >>>>>> >> On Sep 13, 2016, at 11:35 AM, Andrew Gartner <[email protected] >>>>>> >> <mailto:[email protected]>> wrote: >>>>>> >> >>>>>> >> Hey all, >>>>>> >> >>>>>> >> Has anyone tried to add chromaticies to an EXR by hand via oiiotool >>>>>> >> (or python)? >>>>>> >> >>>>>> >> We're starting to expand our color support so for testing I'm trying >>>>>> >> to add it by hand. I believe the attribute is a special case in the >>>>>> >> EXR spec that needs 8 floats (in an array?). however trying this on >>>>>> >> the command line didn't work (I had to wrap in quotes in which case >>>>>> >> it becomes a string) >>>>>> >> >>>>>> >> For example: >>>>>> >> >>>>>> >> oiiotool input.exr -attrib [0,1,0,0,0,0,0,0] -o output.exr >>>>>> >> >>>>>> >> Any help would be welcome. >>>>>> >> >>>>>> >> Cheers, >>>>>> >> >>>>>> >> ~Andrew >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> _______________________________________________ >>>>>> >> Oiio-dev mailing list >>>>>> >> [email protected] <mailto:[email protected]> >>>>>> >> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>>>> >> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>>>>> > >>>>>> > -- >>>>>> > Larry Gritz >>>>>> > [email protected] <mailto:[email protected]> >>>>>> > >>>>>> > >>>>>> > _______________________________________________ >>>>>> > Oiio-dev mailing list >>>>>> > [email protected] <mailto:[email protected]> >>>>>> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>>>> > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>>>>> >>>>>> -- >>>>>> Larry Gritz >>>>>> [email protected] <mailto:[email protected]> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Oiio-dev mailing list >>>>>> [email protected] <mailto:[email protected]> >>>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>>>>> >>>>>> _______________________________________________ >>>>>> Oiio-dev mailing list >>>>>> [email protected] <mailto:[email protected]> >>>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>>>> >>>>> -- >>>>> Larry Gritz >>>>> [email protected] <mailto:[email protected]> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Oiio-dev mailing list >>>>> [email protected] <mailto:[email protected]> >>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Oiio-dev mailing list >>>>> [email protected] <mailto:[email protected]> >>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>>> >>>> -- >>>> Larry Gritz >>>> [email protected] <mailto:[email protected]> >>>> >>>> >>>> _______________________________________________ >>>> Oiio-dev mailing list >>>> [email protected] <mailto:[email protected]> >>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>> >>> -- >>> Larry Gritz >>> [email protected] <mailto:[email protected]> >>> >>> >>> >>> _______________________________________________ >>> Oiio-dev mailing list >>> [email protected] <mailto:[email protected]> >>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >>> >>> >>> _______________________________________________ >>> Oiio-dev mailing list >>> [email protected] <mailto:[email protected]> >>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >> >> -- >> Larry Gritz >> [email protected] <mailto:[email protected]> >> >> >> >> _______________________________________________ >> Oiio-dev mailing list >> [email protected] <mailto:[email protected]> >> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >> >> >> _______________________________________________ >> Oiio-dev mailing list >> [email protected] <mailto:[email protected]> >> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > > > > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org -- Larry Gritz [email protected]
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
