I'm working through getting permission to sign the Corp CLA, to submit PRs but if you'd like this to happen before the next blue moon, don't wait for me :)
although I think the master version already does use path suffixes: https://github.com/OpenImageIO/oiio/blob/master/src/cmake/modules/FindOpenColorIO.cmake my proposed fix would be to stop doing that On Tue, Oct 11, 2016 at 2:50 PM, Larry Gritz <[email protected]> wrote: > Yeah, would one of you guys mind submitting the proper fix as a PR? It's a > lot easier for me to merge a PR than make the changes by hand and hope I > did exactly what you wanted. > > > On Oct 11, 2016, at 2:47 PM, Nathan Rusch <[email protected]> wrote: > > I ran into this last week and forgot to report it after running into > another issue. If I remember correctly, the fix is to change the > `find_path` command to use PATH_SUFFIXES: > > FIND_PATH(OCIO_INCLUDES > OpenColorIO.h > PATHS > ... > PATH_SUFFIXES > OpenColorIO) > > Feel free to submit a PR with this if you want, otherwise I can. > > It's probably worth noting that building against OCIO with `LINKSTATIC` > enabled will fail due to this issue: https://github.com/imageworks/ > OpenColorIO/issues/414 > > > -Nathan > > On 10/12/2016 4:18 AM, Andrew Wood wrote: > > Hey all, > > Trying to build this sucker for the first time (on windows with cmake), so > please let me know if I've got this wrong, however: > > color_ocio.cpp has this include: > #include <OpenColorIO/OpenColorIO.h> > > but FindOpenColorIO.cmake specifies "OpenColorIO" as a suffix. So the > resulting compile command ends up with an extra OpenColorIO directory on > the end like this: > > /I"C:\Users\Username\Documents\code\oiio\1.7\oiio\ > deps\OpenColorIO\include\OpenColorIO" > > and it complains "Cannot open include file: 'OpenColorIO/OpenColorIO.h': > No such file or directory" > > What I've done is change FindOpenColorIO to this and it seems to work: > > FIND_PATH(OCIO_INCLUDES > OpenColorIO/OpenColorIO.h > PATHS > ${OCIO_INCLUDE_PATH} > ${OCIO_PATH}/include/ > /usr/include > /usr/local/include > /sw/include > /opt/local/include > DOC "The directory where OpenColorIO/OpenColorIO.h resides") > > I'm happy to submit a PR with this... but I'm not a cmake pro, so I > figured I'd ask how/if this was working for everyone else but me. I think > with this change we could add ocio back to the appveyor.yml! > > anybody? > thanks! > Andrew > > > _______________________________________________ > Oiio-dev mailing > [email protected]http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > > > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > > > -- > Larry Gritz > [email protected] > > > > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > >
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
