In master / RB-2.0 we just committed a series of changes that reformat the entire code base -- mostly extremely minor changes, but very widespread.
Henceforth, we will assume that any new code contributions should conform to the house style and we will reject pull requests that do not. This is completely automated by clang-format. The basic idea is: 1. For large code changes, make sure you have a fairly recent version of clang-format installed on your end, and use make clang-format to format the code before checking it in and sending off the PR. 2. The TravisCI tests include one entry that merely does a 'make clang-format' and considers it an error if there are any resulting diffs (i.e. if clang-format needed to reformat anything). In such a case, it will also print the diffs themselves if you click on the failed test, making it easy to see what needs to be fixed. Note that for small patches by users who aren't easily able to have a local clang-format copy, you can essentially skip step 1, submit your PR as-is and then examine the failure diffs of step 2, making the requested changes by hand and then updating your PR. -- Larry Gritz [email protected] _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
