Tom:

AFAIK, Checkstyle[1] is licensed under the LGPL. If this is the case, we
cannot distribute it in a OJB release. :-(

Best Regards,

Antonio Gallardo.

[EMAIL PROTECTED] wrote:

tomdz       2005/12/21 14:19:39

 Modified:    .        Tag: OJB_1_0_RELEASE build.xml build.properties
 Added:       src/check Tag: OJB_1_0_RELEASE ojb-checks.xml
                       license-check.txt
              lib      Tag: OJB_1_0_RELEASE checkstyle-all-4.1.jar
 Log:
 Added checkstyle target in the build file (currently it only checks for 
Javadoc problems and that there is the correct license present in the source 
files)
[1] http://sourceforge.net/projects/checkstyle/

Revision Changes Path
 No                   revision
 No                   revision
 1.1.2.1   +146 -0    db-ojb/src/check/Attic/ojb-checks.xml
1.1.2.1 +16 -0 db-ojb/src/check/Attic/license-check.txt No revision
 No                   revision
 1.144.2.30 +22 -1     db-ojb/build.xml
Index: build.xml
 ===================================================================
 RCS file: /home/cvs/db-ojb/build.xml,v
 retrieving revision 1.144.2.29
 retrieving revision 1.144.2.30
 diff -u -r1.144.2.29 -r1.144.2.30
 --- build.xml  13 Dec 2005 20:29:20 -0000      1.144.2.29
 +++ build.xml  21 Dec 2005 22:19:38 -0000      1.144.2.30
 @@ -1583,6 +1583,27 @@
        </condition>
        </target>
+ <!-- ================================================================== -->
 +    <!-- Runs Checkstyle over OJB                                      -->
 +    <!-- ================================================================== 
-->
 +    <target name="checkstyle"
+ depends="prepare" + description="Checks the sourcecode via Checkstyle">
 +      <taskdef resource="checkstyletask.properties"
 +               classpathref="compilation-classpath"/>
+ + <mkdir dir="${build.check}"/> + <checkstyle config="${src.check}/ojb-checks.xml"
 +                  failOnViolation="false"
 +                  classpathref="compilation-classpath">
 +        <fileset dir="${src.java}"
 +                 includes="**/*.java"/>
+ + <formatter type="plain" usefile="false"/>
 +        <!-- Location of cache-file (project specific) -->
 +        <property key="checkstyle.cache.file" 
file="${build.check}/checkstyle/cachefile"/>
 +      </checkstyle>
 +    </target>
<!-- ================================================================== -->
      <!-- Targets for the sample session bean ejb jar                        
-->
1.64.2.14 +7 -1 db-ojb/build.properties Index: build.properties
 ===================================================================
 RCS file: /home/cvs/db-ojb/build.properties,v
 retrieving revision 1.64.2.13
 retrieving revision 1.64.2.14
 diff -u -r1.64.2.13 -r1.64.2.14
 --- build.properties   11 Dec 2005 20:03:08 -0000      1.64.2.13
 +++ build.properties   21 Dec 2005 22:19:38 -0000      1.64.2.14
 @@ -87,6 +87,7 @@
  src.forrest=${src.doc}/forrest
  src.javadoc=${src.doc}/javadoc
  src.ojb-blank=${src.dir}/ojb-blank
 +src.check=${src.dir}/check
  ojb=${source}/ojb
  etc=${source}/etc
  test=${build.dir}/test
 @@ -110,6 +111,7 @@
  build.test = ${build.dir}/test
  build.doc=${build.dir}/doc
  build.javadoc=${build.dir}/javadoc
 +build.check= ${build.dir}/check
  junit.dir = ${build.dir}/test/ojb
  junit.fork=true
@@ -209,6 +211,10 @@
  versiondate=2005-10-23
  ojb-filename-prefix=${project-name}-${version}
+#checkstyle.version.pattern=\\$Revision.*\\$
 +#checkstyle.author.pattern=\\S
 +checkstyle.license.file=${src.check}/license-check.txt
 +
  #
  ### ANT properties end here
No revision
 No                   revision
 1.1.2.1   +6722 -0   db-ojb/lib/Attic/checkstyle-all-4.1.jar
<<Binary file>>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to