svn commit: r452271 - in /db/ojb/trunk/src/java/org/apache/ojb/broker/platforms: Platform.java PlatformDefaultImpl.java PlatformSapdbImpl.java

[arminw]

Author: arminw
Date: Mon Oct  2 16:58:43 2006
New Revision: 452271

URL: http://svn.apache.org/viewvc?view=rev&rev=452271
Log:
add method to check whether or not ORDER BY clause is allowed in sub-select

Modified:
    db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/Platform.java
    
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformDefaultImpl.java
    db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java

Modified: db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/Platform.java
URL: 
http://svn.apache.org/viewvc/db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/Platform.java?view=diff&rev=452271&r1=452270&r2=452271
==============================================================================
--- db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/Platform.java 
(original)
+++ db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/Platform.java Mon Oct 
 2 16:58:43 2006
@@ -45,13 +45,15 @@
 
     /**
      * Called by [EMAIL PROTECTED] 
org.apache.ojb.broker.accesslayer.StatementManager} implementation
-     * before invoking <tt>stmt.close()</tt> method.
+     * on resource cleanup (result and statement instances) before closing the
+     * [EMAIL PROTECTED] java.sql.Statement} instance (nevertheless the 
statement can be <em>null</em>).
      */
     public void beforeStatementClose(Statement stmt, ResultSet rs) throws 
PlatformException;
 
     /**
      * Called by [EMAIL PROTECTED] 
org.apache.ojb.broker.accesslayer.StatementManager} implementation
      * after invoking <tt>stmt.close()</tt> method.
+     * @see #beforeStatementClose(java.sql.Statement, java.sql.ResultSet) 
      */
     public void afterStatementClose(Statement stmt, ResultSet rs) throws 
PlatformException;
 
@@ -241,6 +243,13 @@
      * @return <code>true</code> if it is supported
      */
     boolean supportsMultiColumnCountDistinct();
+
+    /**
+     * Whether the platform supports a ORDER BY clause in SUB-SELECT 
statements.
+     *
+     * @return <code>true</code> if it is supported
+     */
+    boolean supportsOrderByInSubSelect();
 
     /**
      * Concatenate the columns </br>

Modified: 
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformDefaultImpl.java
URL: 
http://svn.apache.org/viewvc/db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformDefaultImpl.java?view=diff&rev=452271&r1=452270&r2=452271
==============================================================================
--- 
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformDefaultImpl.java 
(original)
+++ 
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformDefaultImpl.java 
Mon Oct  2 16:58:43 2006
@@ -534,6 +534,11 @@
         return true;
     }
 
+    public boolean supportsOrderByInSubSelect()
+    {
+        return true;
+    }
+
     /**
      * @see 
org.apache.ojb.broker.platforms.Platform#concatenate(java.lang.String[])
      */

Modified: 
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java
URL: 
http://svn.apache.org/viewvc/db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java?view=diff&rev=452271&r1=452270&r2=452271
==============================================================================
--- 
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java 
(original)
+++ 
db/ojb/trunk/src/java/org/apache/ojb/broker/platforms/PlatformSapdbImpl.java 
Mon Oct  2 16:58:43 2006
@@ -167,7 +167,10 @@
      */
     public boolean useCountForResultsetSize()
     {
-        return true;
+        /*
+        arminw: current driver versions seems to support getRow correctly
+        */
+        return false;
     }
 
     public String createSequenceQuery(String sequenceName)
@@ -283,5 +286,10 @@
     public boolean supportsPaging()
     {
         return true;
-    }    
+    }
+
+    public boolean supportsOrderByInSubSelect()
+    {
+        return false;
+    }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]