> On Aug. 5, 2011, 10:07 p.m., Albert Astals Cid wrote: > > I wonder if we can ever end up in this code, because > > Albert Astals Cid wrote: > Wops, here comes the full comment >D > > I wonder if we can ever end up in this code, because the else is for zip > files containing a fb2 file but the .desktop file of the plugin says it > supports application/x-fictionbook+xml so i can not see a way that the code > flow ends up in that else branch of the if, so we can either just push your > code because it is techinically "correct" or remove all the if altogether :D
You call, I'm fine with committing and I'm fine with you removing all together :). Maintainer! - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/#review5420 ----------------------------------------------------------- On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102220/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2011, 7:52 a.m.) > > > Review request for Okular. > > > Summary > ------- > > While on the plane Albert and I, we decided to fix okular stuff. > > This was something to do, hope that helps. > > Deletes a resource that is never freed. > > > Diffs > ----- > > generators/fictionbook/document.cpp e943566 > > Diff: http://git.reviewboard.kde.org/r/102220/diff > > > Testing > ------- > > None, didn't have any fictionbook to try. > > > Thanks, > > Aleix > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
