-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103517/
-----------------------------------------------------------
(Updated Dec. 27, 2011, 9:04 a.m.)
Review request for Okular and Albert Astals Cid.
Changes
-------
Fix bug where Contents sidebar item is highlighted after auto-reload even when
sidebar is collapsed.
Description
-------
When working on a PDF with the OpenTOC flag set, such as those generated by
LaTeX, it's a bit annoying that the Navigation Panel (aka sidebar) keeps
popping up, even if it was collapsed.
It is understandable that Okular respects the flag when a file is initially
opened, but when working on a document with Okular next to your editor, it's
distracting that I repeatedly have to collapse the sidebar again.
This patch:
- Adds a setCollapsed(bool)/isCollapsed() API to Sidebar and
changes relevant places to use the new API.
- Make sure Okular remembers the collapsed state of the
sidebar when a file is automatically reloaded due to a file
change.
Okular will still respect the OpenTOC file when a file is opened the first
time, just like before.
This addresses bug 289010.
http://bugs.kde.org/show_bug.cgi?id=289010
Diffs (updated)
-----
part.h cae5af0
part.cpp 7db0c0b
ui/sidebar.h 60dc7d6
ui/sidebar.cpp b26d65d
Diff: http://git.reviewboard.kde.org/r/103517/diff/diff
Testing
-------
- Tested that Okular will remember the collapsed state of the sidebar when a
file is automatically reloaded.
- Tested that Okular will still respect the OpenTOC and show the sidebar+TOC
when a file is opened for the first time.
Thanks,
Elvis Stansvik
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
