-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103427/
-----------------------------------------------------------
(Updated Jan. 27, 2012, 8:58 a.m.)
Review request for Okular.
Changes
-------
rc files updated to eliminate the additional toolbar.
Description
-------
The bug (and duplicates) suggests that the page bar which normally appears at
the bottom of the Okular window could be docked in the toolbar, in order to
save vertical screen space which is especially useful on a wide screen. This
patch implements that.
There can only be one MiniBar in existence, because of the fixed observer ID
(which must be unique). So the page tool only appears in the toolbar if the
page bar is hidden; if it is shown, then the page number and size label
appears there as before. The MiniBar is reparented in
Part::slotShowBottomBar() when the page bar is shown or hidden.
The page tool is placed in its own toolbar by default, so that it can be
positioned or floated in accordance with the user's preference.
There are GUI changes and a new I18N string, so this change (if accepted) would
be targeted at KDE SC 4.8.1 or later.
This addresses bug 279128.
http://bugs.kde.org/show_bug.cgi?id=279128
Diffs (updated)
-----
core/observer.h 266993c
part-viewermode.rc dbd8e42
part.h a4ab8aa
part.cpp cd0b695
part.rc 33d3829
ui/minibar.h e91a0fd
ui/minibar.cpp 7e77dec
Diff: http://git.reviewboard.kde.org/r/103427/diff/diff
Testing
-------
Built Okular from master with these changes. Checked operation in both
embedded and standalone modes with page bar shown or not, with a variety of PDF
files.
Screenshots
-----------
With page bar shown
http://git.reviewboard.kde.org/r/103427/s/372/
With page bar hidden
http://git.reviewboard.kde.org/r/103427/s/373/
Thanks,
Jonathan Marten
_______________________________________________
Okular-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/okular-devel
