----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review15696 -----------------------------------------------------------
This looks great, there is only one problem left, since we now have two config files, when you go from an okular using the old files to one using the new ones, "half" of your settings are lost. Could you have a look at http://techbase.kde.org/Development/Tools/Using_kconf_update ? It offers a solution to this problem. - Albert Astals Cid On June 19, 2012, 7:23 p.m., Bogdan Cristea wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104947/ > ----------------------------------------------------------- > > (Updated June 19, 2012, 7:23 p.m.) > > > Review request for Okular. > > > Description > ------- > > Default settings file should be separated in two different files in order to > have a better separation between okular core library (back end) and the front > end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request > includes only the separation of okular.kcfg in two files: > -okular.kcfg (front end) > -okular_core.kcfg (back end) > > > Diffs > ----- > > CMakeLists.txt 0034cf3 > conf/okular.kcfg 6ad0e19 > conf/okular_core.kcfg PRE-CREATION > conf/settings.kcfgc 0b70390 > conf/settings_core.kcfgc PRE-CREATION > core/document.cpp 0ebc34e > core/script/kjs_fullscreen.cpp c07ac4e > core/texteditors_p.h 171dc69 > ui/pagepainter.cpp ca55e81 > ui/pageview.cpp 4be5e6b > ui/presentationwidget.cpp a3b8be4 > > Diff: http://git.reviewboard.kde.org/r/104947/diff/ > > > Testing > ------- > > No > > > Thanks, > > Bogdan Cristea > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
