----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ -----------------------------------------------------------
(Updated Dec. 31, 2012, 8:17 p.m.) Review request for Okular. Changes ------- Fixing "buddy" problem by calling QFormLayout::addRow(QWidget*, QWidget*) instead of QFormLayout::addRow(const QString &, QWidget*). Minor fix in the mimetype label internationalization. Description ------- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: "PDF Document (application/pdf)" Diffs (updated) ----- ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing ------- Screenshots ----------- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
