> On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: > > You prefer this over the TryExec solution? Works for me. > > > > Please make sure you commit this to KDE/4.10 first and then merge to master > > (you'll have to take care the txt backend is only in master) > > Marco Martin wrote: > hmm, yeah, in this case in distributions if they are packaged separately > then only okular desktop is installed the same problem would still occur > > will convert to TryExec. > however iirc i think okular active was merged shortly after 4.10, at > least i don't have it in KDE/4.10 branch > > Albert Astals Cid wrote: > okular active is definitely there in the KDE/4.10 branch, see > http://quickgit.kde.org/?p=okular.git&a=tree&hb=fd22b42b264f6f8e35934eb8fb5a6a0e1d1313ae
ah, yeah, i see, okular active was there, but all the mimetypes were in the only desktop file of the app, were moved to different desktop files for generators afterwards. do i port 4.10 to separate desktop files as well, or leave only master? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 ----------------------------------------------------------- On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109047/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8:04 p.m.) > > > Review request for Okular. > > > Description > ------- > > this should solve https://bugs.kde.org/show_bug.cgi?id=314981 > > when the active app is not compiled the active desktop files don't get > installed > > > Diffs > ----- > > CMakeLists.txt e40cfd6 > active/CMakeLists.txt 1a8ff74 > generators/chm/CMakeLists.txt e54affc > generators/comicbook/CMakeLists.txt 4df23a6 > generators/djvu/CMakeLists.txt 8ca545c > generators/dvi/CMakeLists.txt 30b7394 > generators/epub/CMakeLists.txt f076ed9 > generators/fax/CMakeLists.txt f3a321c > generators/fictionbook/CMakeLists.txt 4fe3877 > generators/kimgio/CMakeLists.txt b0a61eb > generators/ooo/CMakeLists.txt 5d11daf > generators/plucker/CMakeLists.txt c376467 > generators/poppler/CMakeLists.txt 0964fff > generators/spectre/CMakeLists.txt 617047a > generators/tiff/CMakeLists.txt bab056f > generators/txt/CMakeLists.txt 5a126b7 > generators/xps/CMakeLists.txt 6bd8e58 > > Diff: http://git.reviewboard.kde.org/r/109047/diff/ > > > Testing > ------- > > tried to install both with and without active_found > > > Thanks, > > Marco Martin > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel