----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review27846 -----------------------------------------------------------
ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20868> Mere looks, please put the static on front ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20867> This regexp still needs some tweaking, right now if i pass "holahttps://okular.org"; it returns https://okular.org that in my opinion is not correct. You should enforce spaces (or newlines or tabs) around the regexp to make sure the url is a single word. Also it would be cool if you could write down all the urls you've used to positively and negatively test the regexp so we can put it in a testcase ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20866> return QString() not "" - Albert Astals Cid On Feb. 20, 2013, 2:21 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108614/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2013, 2:21 p.m.) > > > Review request for Okular. > > > Description > ------- > > When selected text is right clicked, it checks for a url, if found, a QAction > is added to open the url in the default browser. > > > This addresses bug 281027. > http://bugs.kde.org/show_bug.cgi?id=281027 > > > Diffs > ----- > > ui/pageview.cpp 60a273d > > Diff: http://git.reviewboard.kde.org/r/108614/diff/ > > > Testing > ------- > > just check if the icon appears properly, because I have an issue with the > icon. > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
