https://bugs.kde.org/show_bug.cgi?id=319442
Bug ID: 319442 Summary: Initial contents of Inline Note annotation discarded Classification: Unclassified Product: okular Version: 0.16.60 Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: jon.me...@gmail.com The initial contents of an Inline Note annotation are not preserved when the note 's contents are later edited. Reproducible: Always Steps to Reproduce: 1. Create an inline annotation 2. Enter some initial text in the popup window (The inline note will be created with these contents). 3. Double click the newly created inline note 4. Observe what text the popup annotation window is populated with Actual Results: The popup window's text is empty Expected Results: The popup window should be populated with the initial text entered in step (2) above It looks like the problem is that when the inline note annotation is created the initial text is set using Annotation::setInplaceText (Reference 1), however the annotation popup window is populated using the annotation's contents (Reference 2). When the undo/redo functionality was added the intention was to do away with the distinction between an annotation's contents and inplaceText (See discussion in https://git.reviewboard.kde.org/r/107442/), but this case was not addressed. Proposal: Remove m_inplaceText member from annotationPrivate but remap calls to Annotation::(set)inPlaceText to calls to Annotation::(set)contents for backwards compatibility. While investigating I noticed that the function in Reference 3 should also be cleaned up when this is fixed. References: 1) PickPointEngine::end in pageviewannotator.cpp 2) AnnotWindow::AnnotWindow 3) DocumentPrivate::performSetAnnotationContents in document_p.cpp -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel