> On May 18, 2013, 11:47 a.m., Fabio D'Urso wrote: > > Hi, thank you for noticing, however this patch looks wrong to me: it's > > assigning txtann's contents variable to itself. > > > > I remember why I added this special case, because Poppler < 0.20 sometimes > > stored garbage in the DOM node corresponding to inplaceText (but good data > > in contents). > > This code copied the good value into inplaceText, so that Okular's UI code, > > which used to show the user what it read from inplaceText, showed the good > > value instead. > > > > Now that Okular only has contents, this special handling is no longer > > needed, therefore that block can be removed at all. I'm fixing it myself. > > Thank you again for testing poppler 0.18, which I had forgotten to check > > when I reviewed the other patch :)
You are welcome. So I just close this issue. - Azat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110480/#review32720 ----------------------------------------------------------- On May 17, 2013, 12:13 a.m., Azat Khuzhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110480/ > ----------------------------------------------------------- > > (Updated May 17, 2013, 12:13 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Description > ------- > > Seems than poppler used it. > And compilation error occurs. > > > Diffs > ----- > > generators/poppler/annots.cpp 3694188 > > Diff: http://git.reviewboard.kde.org/r/110480/diff/ > > > Testing > ------- > > Compiling is ok > > > Thanks, > > Azat Khuzhin > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
