----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109627/#review34918 -----------------------------------------------------------
This review has been submitted with commit 4d4dd68ca2c7eea47216c134c84eec85588890e1 by Albert Astals Cid on behalf of Peter Grasch to branch master. - Commit Hook On June 17, 2013, 11:33 a.m., Peter Grasch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109627/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 11:33 a.m.) > > > Review request for Okular. > > > Description > ------- > > Multiple features in Okular require to determine what object is at a given > position. Traditionally, this relied on the bounding boxes of the given > object. > These do not necessarily correlate with the user would expect (for example, a > diagonal line of 1px has a very large bounding box). > > This patch implementes shape based selection for the following annotation > types: > Ink, Geometric, Line, Highlight. > Other objects default to the old behaviour. > > > Diffs > ----- > > core/annotations.h 79fd965 > core/annotations.cpp 353759b > core/annotations_p.h f9a342f > core/area.h 4f63759 > core/area.cpp d772fc0 > core/page.cpp a6fa623 > tests/CMakeLists.txt 63c5c35 > tests/annotationstest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109627/diff/ > > > Testing > ------- > > I tested the annotation objects above and a couple of special cases mentioned > in the IRC. > > > Thanks, > > Peter Grasch > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
