----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111554/#review36256 -----------------------------------------------------------
generators/epub/converter.cpp <http://git.reviewboard.kde.org/r/111554/#comment26822> The 800 comes from somewhere else, no? Please use that and not a hardcoded 800 Also i'm still unconvinced about that hardcoded 42, have you investigated where that number comes from? - Albert Astals Cid On July 19, 2013, 8:29 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111554/ > ----------------------------------------------------------- > > (Updated July 19, 2013, 8:29 p.m.) > > > Review request for Okular. > > > Description > ------- > > Epubs use the below syntax to load svg images > > <svg> > <image width="592" height="900" xlink:href="images/cover.svg" /> > </svg> > > I just replace that with <img> tags & add QImage as a resource. > > > Diffs > ----- > > generators/epub/CMakeLists.txt 9442f61 > generators/epub/converter.cpp 74df151 > generators/epub/epubdocument.h 714ede6 > > Diff: http://git.reviewboard.kde.org/r/111554/diff/ > > > Testing > ------- > > The below link contains two epub files having svg images as cover. > https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
