----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111782/#review37802 -----------------------------------------------------------
Ship it! To be honest I can't see why it would have a binding loop after looking at the code If you think it works, please commit it. To which branch i don't know, 4.11 i guess? - Albert Astals Cid On July 29, 2013, 6:48 p.m., Fabio D'Urso wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111782/ > ----------------------------------------------------------- > > (Updated July 29, 2013, 6:48 p.m.) > > > Review request for Okular. > > > Description > ------- > > As Marco Martin discovered, at some zoom levels on my laptop okular active > tries to draw page pixmaps at non-exact pixel boundaries, resulting in almost > unreadable text (see attached video). > > This patch fixes the issue by rounding the page position to the nearest > pixel. Unfortunately, this patch also seems introduce a binding loop: > QML PageItem_QML_18: Binding loop detected for property "x" > > I'm creating this review request as remainder for further investigation. > > > Diffs > ----- > > active/app/package/contents/ui/FullScreenDelegate.qml ac308aa > > Diff: http://git.reviewboard.kde.org/r/111782/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screen recording of the issue > > http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/screen-recording.ogv > > > Thanks, > > Fabio D'Urso > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
