----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/ -----------------------------------------------------------
(Updated Oct. 18, 2013, 2:44 p.m.) Status ------ This change has been marked as submitted. Review request for Okular. Bugs: 323262 and 323263 http://bugs.kde.org/show_bug.cgi?id=323262 http://bugs.kde.org/show_bug.cgi?id=323263 Repository: okular Description ------- This patch solves Bug 323262 and Bug 323263. I also refactored and simplified the code a little. By removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)). (I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.) Diffs ----- core/textpage_p.h 8ecf0c9 core/textpage.cpp 855942d tests/searchtest.cpp 495107d Diff: http://git.reviewboard.kde.org/r/112135/diff/ Testing ------- Thanks, Jaan Vajakas
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel