----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114060/ -----------------------------------------------------------
(Updated Nov. 24, 2013, 2:23 a.m.) Review request for Okular. Repository: okular Description (updated) ------- This patch introduces viewport transitions for undo/redo actions on annotations and forms. When an annotation/form action is undone/redone but the associated annotation/form is not currently visible, the viewport is updated to center on the undo/redo action. If the annotation/form is visible, the viewport is not updated. The viewport transitions for the Find action have also been updated to this same algorithm. Previously the viewport was moved to center on each matching search term even if the search term was already visible in the viewport. This lead to unnecessary viewport transitions if the search term matched several items in a single paragraph for example. These proposed changes to the viewport transition behavior are consistent with the find and undo behavior of many existing applications including Kate, Open Office, and Foxit PDF Reader. Diffs ----- core/document.h fe296e0 core/document.cpp 265ee09 core/documentcommands.cpp 7799bb0 core/documentcommands_p.h fe1c577 core/page.cpp 0bafa99 core/utils.h 8d5d5fc core/utils.cpp 5dd8448 Diff: http://git.reviewboard.kde.org/r/114060/diff/ Testing ------- Manual testing of the viewport behavior for find and undo/redo actions on several documents. I also tested that the desired behavior is maintained when documents are rotated. Thanks, Jon Mease
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
