----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113973/ -----------------------------------------------------------
(Updated Nov. 28, 2013, 11:37 a.m.) Review request for Okular. Changes ------- new patch with suggested changes. The BIG pixmap issue, please see https://git.reviewboard.kde.org/r/113986/ for that. Repository: okular Description ------- I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it. The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward. The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another. So the remaining question is, what is the status of this: core/document_p.h:213 "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one" Is someone working on it? Diffs (updated) ----- CMakeLists.txt 217337f conf/okular.kcfg deabd07 ui/magnifierview.h PRE-CREATION ui/magnifierview.cpp PRE-CREATION ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: http://git.reviewboard.kde.org/r/113973/diff/ Testing ------- File Attachments ---------------- Allow BIG pixmaps http://git.reviewboard.kde.org/media/uploaded/files/2013/11/20/52c4f894-2286-421e-8025-45027d93524e__01-hack.patch Thanks, Michal Humpula
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
