> On Feb. 17, 2014, 9:53 p.m., Albert Astals Cid wrote: > > active/components/documentitem.cpp, line 210 > > <https://git.reviewboard.kde.org/r/113986/diff/5/?file=244457#file244457line210> > > > > Doesn't this add the observer twice? > > Michal Humpula wrote: > This is a plasma extension (?), completely separated from everything > else. And as far as I can tell, there is no duplication. > > Albert Astals Cid wrote: > Really? > > m_pageviewObserver = new Observer(this); > m_document->addObserver( m_pageviewObserver ); > > and > > Observer::Observer(DocumentItem *parent) > : QObject(parent), > m_document(parent) > { > parent->document()->addObserver(this); > } > > I'd say that m_pageviewObserver is added twice, no?
Nasty... - Michal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review50107 ----------------------------------------------------------- On Feb. 19, 2014, 5:56 a.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113986/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 5:56 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > First shot for multiple tiles managers way. Let's face it -- it's nasty. But > the compiled okular is displaying my testing pdf without crashing, so at > least that. > > It's straighforward implementation. Every single place, where there were call > for (or with) TilesManager, now has a DocumentObserver as companion. The > m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, > TilesManager>. > > It's adding more code then I expected, but I think that now, when every > request can be back-supported by TilesManager, all the request can now be > served trought them and not by that direct Pixmap cache in Document. So with > that, it would actually be more deletion (imho). > > > Diffs > ----- > > active/components/documentitem.cpp aaf98b3 > core/document.h fe296e0 > core/document.cpp 19eaa70 > core/document_p.h ef25169 > core/generator.cpp 23b274b > core/generator_p.h 9021763 > core/page.h bc8c09e > core/page.cpp e194523 > core/page_p.h 63d4da1 > part.cpp 283e91a > ui/pagepainter.cpp d5d9c3e > ui/pageview.cpp 65967bf > > Diff: https://git.reviewboard.kde.org/r/113986/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
