----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review56806 -----------------------------------------------------------
ui/pageview.cpp <https://git.reviewboard.kde.org/r/112370/#comment39649> The code in ZoomIn and ZoomOut seem to be very much the same (can only find a -1 difference) I think you should put the code as case ZoomIn: case ZoomOut: // the code so that there is less repeated code. What's your opinion? - Albert Astals Cid On April 27, 2014, 11:23 p.m., Tingnan Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112370/ > ----------------------------------------------------------- > > (Updated April 27, 2014, 11:23 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > BugFix 323434/323435. Zoom factor now will be properly rounded to those > "interval values" like 140%, 250%, etc, when using zoom in and out feature. > > > Diffs > ----- > > ui/pageview.cpp b00dd3e9201f6b606ae4c064bb95d504563cab09 > ui/pageview.h 287da3a26297e39a275cac9b5276181987640a86 > > Diff: https://git.reviewboard.kde.org/r/112370/diff/ > > > Testing > ------- > > done on local machine > > > Thanks, > > Tingnan Zhang > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel