> On abr. 28, 2014, 10:09 p.m., Albert Astals Cid wrote: > > Hmmm, Yichao, there's still work to be done about this, no? At least it > > seems to me we had a conversation in Feb 7 that needed you to do some > > changes and the last diff is from Feb 4. > > Yichao Zhou wrote: > Yes. I will do that. But as an student I'm a little busy this semester. > I think I will finish all these patches in June. > > Albert Astals Cid wrote: > No worries :)
June is gone. Do you think you'll have time for this? Or can I discard this review to get an easier to manage dashboard in reviewboard and you open a new review request when you can work on the remaining issues? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review56802 ----------------------------------------------------------- On feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115335/ > ----------------------------------------------------------- > > (Updated feb. 4, 2014, 4:39 a.m.) > > > Review request for Okular. > > > Bugs: 219121 > http://bugs.kde.org/show_bug.cgi?id=219121 > > > Repository: okular > > > Description > ------- > > According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I > implemented that feature with an option in accessibility pages. > > > This patch also fixes some problems in the original patch, and provides more > features, including > * In scroll mode, you can press ctrl key to enter zoom mode > * Now you can use middle key to scroll in all mouse mode (broswer, zoom, > selection, etc.) > * In scroll mode, now okular can load new page correctly > > > Diffs > ----- > > conf/dlgaccessibilitybase.ui 9e76a75 > conf/okular.kcfg deabd07 > ui/pageview.h 9c15af6 > ui/pageview.cpp 65967bf > > Diff: https://git.reviewboard.kde.org/r/115335/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel