> On Aug. 22, 2014, 9:05 a.m., Markus Trippelsdorf wrote: > > I've tested the patch with a number of problematic pdfs and it works fine. > > Thanks. > > Albert Astals Cid wrote: > Can you discard your proposal then?
Done. I hadn't actually tested your patch only, but the combination with my proposal. But your patch alone is enough. Thanks. - Markus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119894/#review65014 ----------------------------------------------------------- On Aug. 21, 2014, 10:08 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119894/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 10:08 p.m.) > > > Review request for Okular, Markus Trippelsdorf and Tingnan Zhang. > > > Bugs: 335819 > http://bugs.kde.org/show_bug.cgi?id=335819 > > > Repository: okular > > > Description > ------- > > In the wild world where each page is of different size, only use the current > page to update the zoom factor in updateItemSize > > > Diffs > ----- > > ui/pageview.cpp 8ceafae > > Diff: https://git.reviewboard.kde.org/r/119894/diff/ > > > Testing > ------- > > Works for me with https://bugs.kde.org/attachment.cgi?id=88318 > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel