----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120311/#review68100 -----------------------------------------------------------
Ship it! The testing I performed on a bunch of pdf and dvi files does not show evident regressions. If I read correctly we need also to bump the libokularcode version. - Luigi Toscano On Set. 22, 2014, 12:22 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120311/ > ----------------------------------------------------------- > > (Updated Set. 22, 2014, 12:22 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > This way dvi and any other potential user gets it for free > > The diff is huge, but the synctex files are just moves. > > And the code in core/ is also mostly just a move from the generator_pdf.cpp > code > > > Diffs > ----- > > > generators/poppler/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff > 4e09637 > generators/poppler/synctex/patches/08-fix_cpp_comments.diff 90413b4 > generators/poppler/synctex/patches/09-fix_path_comparison.diff 984a0a6 > generators/poppler/synctex/patches/series 7497c52 > generators/poppler/synctex/synctex_parser.h 4aca415 > generators/poppler/synctex/synctex_parser.c 8244f27 > generators/poppler/synctex/synctex_parser_local.h 6573b26 > generators/poppler/synctex/synctex_parser_readme.txt ebc06bb > generators/poppler/synctex/synctex_parser_utils.h 92184b8 > generators/poppler/synctex/synctex_parser_utils.c 03da409 > generators/poppler/synctex/synctex_parser_version.txt 03ff897 > generators/poppler/synctex/patches/04-gcc-specify-printf-format.diff > 7b2d796 > generators/poppler/synctex/patches/05-fix-error-formats.diff fad5a9e > generators/poppler/synctex/patches/06-mingw-_synctex_error.diff 5c838d7 > generators/dvi/generator_dvi.cpp a26c6eb > generators/poppler/CMakeLists.txt 4849655 > generators/poppler/generator_pdf.h 2faa0d8 > generators/poppler/generator_pdf.cpp d61b996 > generators/poppler/synctex/patches/00-disable-SYNCTEX_INLINE.diff a28faf1 > generators/poppler/synctex/patches/01-fix-win32-define.diff 75b3198 > core/synctex/synctex_parser_local.h PRE-CREATION > core/synctex/synctex_parser_readme.txt PRE-CREATION > core/synctex/synctex_parser_utils.h PRE-CREATION > core/synctex/synctex_parser_utils.c PRE-CREATION > core/synctex/synctex_parser_version.txt PRE-CREATION > core/synctex/synctex_parser.h PRE-CREATION > core/synctex/synctex_parser.c PRE-CREATION > core/synctex/patches/08-fix_cpp_comments.diff PRE-CREATION > core/synctex/patches/09-fix_path_comparison.diff PRE-CREATION > core/synctex/patches/series PRE-CREATION > core/synctex/patches/04-gcc-specify-printf-format.diff PRE-CREATION > core/synctex/patches/05-fix-error-formats.diff PRE-CREATION > core/synctex/patches/06-mingw-_synctex_error.diff PRE-CREATION > > core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff > PRE-CREATION > CMakeLists.txt 34f9f6a > core/document.cpp 721d36a > core/document_p.h a71912b > core/generator.h 2c12927 > core/generator.cpp e74064e > core/synctex/patches/00-disable-SYNCTEX_INLINE.diff PRE-CREATION > core/synctex/patches/01-fix-win32-define.diff PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120311/diff/ > > > Testing > ------- > > Played with the instructions of > https://bugs.kde.org/show_bug.cgi?id=326605#c19 > > Both latex and pdflatex synctex work now > > latex -src-specials also still works. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
